Code Review for nv93_aes

Prepared by: Daniel Anderson (da73024) on Fri Jun 13 16:45:11 PDT 2008
Workspace:/builds/da73024/nv93_aes
Compare against: /ws/onnv-clone
Summary of changes: 3528 lines changed: 3326 ins; 78 del; 124 mod; 3854 unchg
Patch of changes: nv93_aes.patch
Printable review: nv93_aes.pdf

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/THIRDPARTYLICENSE.cryptogams

6704653 THIRDPARTYLICENSE fixes for open source crypto source
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/THIRDPARTYLICENSE.cryptogams.descrip

6704653 THIRDPARTYLICENSE fixes for open source crypto source
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_cbc_crypt.c

5072963 Need an optimized AES implementation for amd64
6699938 CCM max payload computation is off by one
78 lines changed: 43 ins; 12 del; 23 mod; 1653 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_cbc_crypt.h

5072963 Need an optimized AES implementation for amd64
3 lines changed: 0 ins; 0 del; 3 mod; 131 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_impl.c

5072963 Need an optimized AES implementation for amd64
294 lines changed: 172 ins; 61 del; 61 mod; 1443 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/aes/aes_impl.h

5072963 Need an optimized AES implementation for amd64
30 lines changed: 13 ins; 3 del; 14 mod; 101 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/THIRDPARTYLICENSE

5072963 Need an optimized AES implementation for amd64
23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/THIRDPARTYLICENSE.descrip

5072963 Need an optimized AES implementation for amd64
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/aes_amd64.s

5072963 Need an optimized AES implementation for amd64
893 lines changed: 893 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/aeskey.c

5072963 Need an optimized AES implementation for amd64
581 lines changed: 581 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/aesopt.h

5072963 Need an optimized AES implementation for amd64
768 lines changed: 768 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/aestab.h

5072963 Need an optimized AES implementation for amd64
167 lines changed: 167 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/aes/amd64/aestab2.h

5072963 Need an optimized AES implementation for amd64
596 lines changed: 596 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/md5/amd64/THIRDPARTYLICENSE

6704653 THIRDPARTYLICENSE fixes for open source crypto source
3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/md5/amd64/THIRDPARTYLICENSE.descrip

6704653 THIRDPARTYLICENSE fixes for open source crypto source
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/amd64/Makefile

5072963 Need an optimized AES implementation for amd64
16 lines changed: 8 ins; 0 del; 8 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWckr/Makefile

5072963 Need an optimized AES implementation for amd64
6704653 THIRDPARTYLICENSE fixes for open source crypto source
5 lines changed: 0 ins; 0 del; 5 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcslr/Makefile

6704653 THIRDPARTYLICENSE fixes for open source crypto source
5 lines changed: 1 ins; 0 del; 4 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/opensolaris/license-list

5072963 Need an optimized AES implementation for amd64
6704653 THIRDPARTYLICENSE fixes for open source crypto source
5 lines changed: 1 ins; 1 del; 3 mod; 156 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/aes/Makefile

5072963 Need an optimized AES implementation for amd64
22 lines changed: 18 ins; 1 del; 3 mod; 97 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/arcfour/amd64/THIRDPARTYLICENSE (was usr/src/common/crypto/arcfour/amd64/THIRDPARTYLICENSE)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 36 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/arcfour/amd64/THIRDPARTYLICENSE.descrip (was usr/src/common/crypto/arcfour/amd64/THIRDPARTYLICENSE.descrip)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 1 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/sha1/amd64/THIRDPARTYLICENSE (was usr/src/common/crypto/sha1/amd64/THIRDPARTYLICENSE)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 36 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/sha1/amd64/THIRDPARTYLICENSE.descrip (was usr/src/common/crypto/sha1/amd64/THIRDPARTYLICENSE.descrip)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 1 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE (was usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 36 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE.descrip (was usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE.descrip)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 1 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 2007/09/30). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.