Code Review for nv81_ac4md5

Prepared by: Daniel Anderson (da73024) on Wed Jan 2 14:49:12 PST 2008
Workspace:/builds/da73024/nv81_ac4md5
Compare against: /ws/onnv-clone
Summary of changes: 745 lines changed: 614 ins; 15 del; 116 mod; 4024 unchg
Patch of changes: nv81_ac4md5.patch
Printable review: nv81_ac4md5.pdf

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/arcfour/amd64/arcfour_crypt_amd64.s 

6189743 Need an ARCFOUR implementation optimized for AMD64
165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/arcfour/arcfour_crypt.c 

6189743 Need an ARCFOUR implementation optimized for AMD64
16 lines changed: 10 ins; 1 del; 5 mod; 126 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/md5/amd64/md5_amd64.pl 

5072961 Need an optimized MD5 implementation for amd64
352 lines changed: 352 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/md5/md5.c 

5072961 Need an optimized MD5 implementation for amd64
27 lines changed: 24 ins; 0 del; 3 mod; 673 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/Makefile.com 

5072961 Need an optimized MD5 implementation for amd64
3 lines changed: 0 ins; 0 del; 3 mod; 117 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/amd64/Makefile 

5072961 Need an optimized MD5 implementation for amd64
16 lines changed: 14 ins; 0 del; 2 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/Makefile.softtoken.amd64 

6189743 Need an ARCFOUR implementation optimized for AMD64
10 lines changed: 4 ins; 1 del; 5 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/crypto/common.h 

6189743 Need an ARCFOUR implementation optimized for AMD64
11 lines changed: 6 ins; 1 del; 4 mod; 517 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/aes/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/aes256/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/arcfour/Makefile 

6189743 Need an ARCFOUR implementation optimized for AMD64
16 lines changed: 12 ins; 1 del; 3 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/arcfour2048/Makefile 

6189743 Need an ARCFOUR implementation optimized for AMD64
18 lines changed: 11 ins; 2 del; 5 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/blowfish/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/blowfish448/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/des/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/md5/Makefile 

5072961 Need an optimized MD5 implementation for amd64
20 lines changed: 16 ins; 2 del; 2 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/rsa/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
5 lines changed: 0 ins; 0 del; 5 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/aes/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/aes256/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/arcfour/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/arcfour2048/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/blowfish/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/blowfish448/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/des/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/rsa/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
4 lines changed: 0 ins; 0 del; 4 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/aes/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/aes256/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/arcfour/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/arcfour2048/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
6 lines changed: 0 ins; 1 del; 5 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/des/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/rsa/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
4 lines changed: 0 ins; 0 del; 4 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/arcfour/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/arcfour2048/Makefile 

6617458 amd64/rsa is a false positive reported by wsdiff
3 lines changed: 0 ins; 0 del; 3 mod; 100 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 2007/09/30). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.