Code Review for kcfconf

Prepared by:Daniel OpenSolaris Anderson <opensolaris@drydog.com> on Tue Oct 28 16:46:28 PDT 2008
Workspace:/net/amboy.west/export/workspace/kcfconf (at efed3b4f31ed)
Compare against: /ws/onnv-clone-sanpen (at a5d463530d7f)
Summary of changes: 2160 lines changed: 668 ins; 850 del; 642 mod; 6337 unchg
Patch of changes: kcfconf.patch
Printable review: kcfconf.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/cryptoadm/adm_kef.c

6414175 kcf.conf's supportedlist not providing much usefulness
564 lines changed: 145 ins; 243 del; 176 mod; 1041 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/cryptoadm/adm_kef_ioctl.c

6414175 kcf.conf's supportedlist not providing much usefulness
80 lines changed: 24 ins; 6 del; 50 mod; 533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/cryptoadm/adm_kef_util.c

6414175 kcf.conf's supportedlist not providing much usefulness
417 lines changed: 166 ins; 84 del; 167 mod; 1042 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/cryptoadm/cryptoadm.c

6414175 kcf.conf's supportedlist not providing much usefulness
300 lines changed: 78 ins; 46 del; 176 mod; 1468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/cryptoadm/cryptoadm.h

6414175 kcf.conf's supportedlist not providing much usefulness
26 lines changed: 11 ins; 1 del; 14 mod; 155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/etc/kcf.conf

6414175 kcf.conf's supportedlist not providing much usefulness
25 lines changed: 0 ins; 21 del; 4 mod; 29 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/pkgdefs/SUNWcryptoint/postinstall (deleted)

6414175 kcf.conf's supportedlist not providing much usefulness
94 lines changed: 0 ins; 94 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/pkgdefs/SUNWcryptoint/preremove (deleted)

6414175 kcf.conf's supportedlist not providing much usefulness
82 lines changed: 0 ins; 82 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcryptoint/prototype_com

6414175 kcf.conf's supportedlist not providing much usefulness
2 lines changed: 0 ins; 2 del; 0 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWdcar/postinstall

6414175 kcf.conf's supportedlist not providing much usefulness
68 lines changed: 0 ins; 67 del; 1 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWdcar/preremove

6414175 kcf.conf's supportedlist not providing much usefulness
56 lines changed: 0 ins; 53 del; 3 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWn2cp.v/postinstall

6414175 kcf.conf's supportedlist not providing much usefulness
69 lines changed: 0 ins; 68 del; 1 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWn2cp.v/preremove

6414175 kcf.conf's supportedlist not providing much usefulness
54 lines changed: 0 ins; 51 del; 3 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/core/kcf_cryptoadm.c

6414175 kcf.conf's supportedlist not providing much usefulness
277 lines changed: 216 ins; 29 del; 32 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/core/kcf_prov_tabs.c

6414175 kcf.conf's supportedlist not providing much usefulness
46 lines changed: 28 ins; 3 del; 15 mod; 874 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.