Code Review for nv87_ac4sha2mac64

Prepared by: Daniel Anderson (da73024) on Mon Mar 24 15:33:14 PDT 2008
Workspace:/builds/da73024/nv87_ac4sha2mac64
Compare against: /ws/onnv-clone
Summary of changes: 1495 lines changed: 1365 ins; 49 del; 81 mod; 5823 unchg
Patch of changes: nv87_ac4sha2mac64.patch
Printable review: nv87_ac4sha2mac64.pdf

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/common/crypto/arcfour/amd64/arcfour_crypt_amd64.s

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/digest/Makefile

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
31 lines changed: 11 ins; 5 del; 15 mod; 37 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-crypto/digest/Makefile.com

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-crypto/digest/amd64/Makefile

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/digest/digest.c

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
6 lines changed: 0 ins; 0 del; 6 mod; 939 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-crypto/digest/i386/Makefile

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-crypto/digest/sparc/Makefile

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-crypto/digest/sparcv9/Makefile

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/arcfour/amd64/THIRDPARTYLICENSE

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/arcfour/amd64/THIRDPARTYLICENSE.descrip

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/arcfour/amd64/arcfour-x86_64.pl

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
407 lines changed: 407 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/arcfour/arcfour.h

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
5 lines changed: 3 ins; 0 del; 2 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/arcfour/arcfour_crypt.c

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
35 lines changed: 25 ins; 5 del; 5 mod; 131 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/sha1/amd64/sha1-x86_64.pl

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
3 lines changed: 0 ins; 2 del; 1 mod; 367 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE.descrip

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/amd64/sha512-x86_64.pl

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
396 lines changed: 396 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/sha2/sha2.c

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
68 lines changed: 41 ins; 8 del; 19 mod; 860 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/Makefile.com

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
3 lines changed: 1 ins; 0 del; 2 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/amd64/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
14 lines changed: 7 ins; 4 del; 3 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/Makefile.com

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
17 lines changed: 0 ins; 16 del; 1 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/amd64/Makefile

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
14 lines changed: 8 ins; 2 del; 4 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/i386/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
2 lines changed: 0 ins; 1 del; 1 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcsu/prototype_com

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
4 lines changed: 0 ins; 0 del; 4 mod; 1639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcsu/prototype_i386

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
6 lines changed: 4 ins; 0 del; 2 mod; 166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcsu/prototype_sparc

6658907 digest(1) and mac(1) could benefit from being 64-bit programs
6 lines changed: 4 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/opensolaris/license-list

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
2 lines changed: 2 ins; 0 del; 0 mod; 136 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/crypto/common.h

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
10 lines changed: 3 ins; 4 del; 3 mod; 522 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sha2.h

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
3 lines changed: 0 ins; 0 del; 3 mod; 141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/arcfour/Makefile

6652716 Need an ARCFOUR implementation optimized for Intel EM64T
9 lines changed: 3 ins; 0 del; 6 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sha2/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
23 lines changed: 19 ins; 2 del; 2 mod; 96 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 2007/09/30). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.