Code Review for nv85_sha2

Prepared by: Dan Anderson, x55418 (da73024) on Thu Mar 20 14:24:13 PDT 2008
Workspace:/workspace/danx/nv85_sha2
Compare against: /net/elpaso.sfbay/export/snapshot/onnv_85
Summary of changes: 573 lines changed: 506 ins; 34 del; 33 mod; 2112 unchg
Patch of changes: nv85_sha2.patch
Printable review: nv85_sha2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/sha1/amd64/sha1-x86_64.pl

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
3 lines changed: 0 ins; 2 del; 1 mod; 367 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/amd64/THIRDPARTYLICENSE.descrip

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/common/crypto/sha2/amd64/sha512-x86_64.pl

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
399 lines changed: 399 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/crypto/sha2/sha2.c

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
68 lines changed: 41 ins; 8 del; 19 mod; 860 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/Makefile.com

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
3 lines changed: 1 ins; 0 del; 2 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libmd/amd64/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
14 lines changed: 7 ins; 4 del; 3 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/Makefile.com

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
17 lines changed: 0 ins; 16 del; 1 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/amd64/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
2 lines changed: 0 ins; 1 del; 1 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/pkcs11_softtoken/i386/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
2 lines changed: 0 ins; 1 del; 1 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/opensolaris/license-list

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
2 lines changed: 2 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sha2.h

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
3 lines changed: 0 ins; 0 del; 3 mod; 141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sha2/Makefile

6665607 Need a SHA256/SHA384/SHA512 implementation optimized for 64-bit x86
23 lines changed: 19 ins; 2 del; 2 mod; 96 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 2007/09/30). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.