Code Review for bignum

Prepared by:Dan OpenSolaris Anderson <opensolaris@drydog.com> on Wed Feb 25 22:20:37 PST 2009
Workspace:/builds/da73024/bignum (at 0c81e6c1522d)
Compare against: ssh://onnv.sfbay.sun.com//export/onnv-clone (at 1eb5efc243ad)
Summary of changes: 456 lines changed: 98 ins; 196 del; 162 mod; 4142 unchg
Patch of changes: bignum.patch
Printable review: bignum.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/bignum/README

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
15 lines changed: 7 ins; 3 del; 5 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/bignum/amd64/bignum_amd64.c

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
142 lines changed: 1 ins; 132 del; 9 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/bignum/amd64/bignum_amd64_asm.s

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
31 lines changed: 1 ins; 9 del; 21 mod; 527 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/bignum/bignum.h

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
16 lines changed: 4 ins; 4 del; 8 mod; 210 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/bignum/bignumimpl.c

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
209 lines changed: 84 ins; 41 del; 84 mod; 2890 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/bignum/mont_mulf.c

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
27 lines changed: 0 ins; 4 del; 23 mod; 310 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/libsoftcrypto/amd64/Makefile

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
9 lines changed: 0 ins; 1 del; 8 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/bignum/Makefile.64

6799218 RSA using Solaris Kernel Crypto framework lagging behind OpenSSL
5016936 bignumimpl:big_mul: potential memory leak
6810280 panic from bignum module: vmem_xalloc(): size == 0
7 lines changed: 1 ins; 2 del; 4 mod; 61 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.