Code Review for cryptoadm

Prepared by:Dan OpenSolaris Anderson <opensolaris@drydog.com> on 2009-Dec-21 10:30 -0800 PST
Workspace:/builds/da73024/cryptoadm (at 9569f76978e9)
Compare against: /ws/onnv-clone (at 06c12a9be468)
Summary of changes: 71 lines changed: 24 ins; 9 del; 38 mod; 2393 unchg
Patch of changes: cryptoadm.patch
Printable review: cryptoadm.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/cryptoadm/adm_kef_util.c

6862532 "cryptoadm: failed to parse configuration" error
6353443 domestic (crypt) source build leaves stuff it shouldn't
6818180 mac(1) printed "invalid key" error message when user input an invalid passphrase
46 lines changed: 22 ins; 1 del; 23 mod; 1354 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-crypto/digest/digest.c

6862532 "cryptoadm: failed to parse configuration" error
6353443 domestic (crypt) source build leaves stuff it shouldn't
6818180 mac(1) printed "invalid key" error message when user input an invalid passphrase
15 lines changed: 2 ins; 1 del; 12 mod; 930 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libgss/README.spi

6862532 "cryptoadm: failed to parse configuration" error
6353443 domestic (crypt) source build leaves stuff it shouldn't
6818180 mac(1) printed "invalid key" error message when user input an invalid passphrase
10 lines changed: 0 ins; 7 del; 3 mod; 109 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.